It should hide the sub-options when `show sidebar` is not selected if we wanted to save real-estate, but whats the point, it will be on most of the time, and then having the sub-options visible is better than a dropdown or expander.
So I agree with just using what @b4n illustrated.
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/581#issuecomment-170407029
@kugel- the current version here looks like this:
Regarding the drop down, I don't think it's a great idea for this as there are only 2 options and we already have radio options for similar cases. But we use both somewhat randomly so, well.
-------
> What about using "Default sort mode:" or "Initial sort mode:" for the label? It might make it clearer the settings is applied only upon file opening but not if the settings is changed later.
Why not indeed, done in my followup patches: https://github.com/b4n/geany/commits/wip/techee/symbollist_sort
There are two commits: [one changing the UI and the settings layout](https://github.com/b4n/geany/commit/cda78b994cb6a74ae02b487d25e8c70…, and [one switching to stash prefs because it's shorter and simpler](https://github.com/b4n/geany/commit/7738a1fdc868aa68e28820f0c87f44…. Feel free to squash at your convenience, even making one single commit from yours and mine.
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/581#issuecomment-170404783
>
> @tchee There is a bug in the prefs UI: when deactivating "show sidebar",
> the new option isn't grayed out. What I'd do is make the whole vbox46
> insensitive in on_sidebar_visible_toggled() -- and renamed the glade ID
> to something more sensible, like i.e. box_sidebar_visible_children or
> alike.
>
Sounds good, thanks for noticing.
> ------------------------------
>
> Also, what about using an multi-choice UI like this (or a drop-down, but
> well) instead of a checkbox?:
> [image: capture]
> <https://cloud.githubusercontent.com/assets/793526/12222199/63be1498-b7b5-11…>
> This would
>
> - make it easier for the user to see the available options
> - make it easier to add new options in the future (although unlikely)
>
> Yeah, looks nicer (I'd prefer the radios instead the drop-down). What
about using "Default sort mode:" or "Initial sort mode:" for the label? It
might make it clearer the settings is applied only upon file opening but
not if the settings is changed later.
>
>
> And while at it, what about storing the actual sort mode in the prefs
> instead of a flag? Again, scales better.
>
Sounds good too.
> If we want the above, I have some working version I could polish and
> publish.
>
Great, will have a look at your changes.
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/581#issuecomment-170374561
@tchee There is a bug in the prefs UI: when deactivating "show sidebar", the new option isn't grayed out. What I'd do is make the whole `vbox46` insensitive in `on_sidebar_visible_toggled()` -- and renamed the glade ID to something more sensible, like i.e. `box_sidebar_visible_children` or alike.
---
Also, what about using an multi-choice UI like this (or a drop-down, but well) instead of a checkbox?:
This would
* make it easier for the user to see the available options
* make it easier to add new options in the future (although unlikely)
And while at it, what about storing the actual sort mode in the prefs instead of a flag? Again, scales better.
If we want the above, I have some working version I could polish and publish.
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/581#issuecomment-170359728
The code deciding whether to popup a normal completion or scope completion could be improved as @b4n described:
Just a thought (I don't think it has anything to do directly with the changes here, but it's related to scope completion): it'd be nice to trigger scope completion back when continuing on typing on a word after a scope element, instead of only when actually typing the scope separator. E.g the user could cancel the autoc some way, and get back to it without re-typing the separator.
```
static struct {
int first, second;
} foo;
int main(void) {
return foo.f/*cursor*/; // <- here, typing "o" would show "first"
}
```
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/861
Not sure when this started, and not sure why I didn't report this earlier. Open a latex file, and write an unmatched `[` (opening square bracket) after a command in math mode, i.e.: `$ a \in [0,2\pi) $`
Expected behavior: Geany/ctags/IDon'tKnow still knows that we're in math mode, so an opening bracket does not necessarily start an optional argument.
Actual behavior: the opening bracket causes *everything* after it (including the text after math mode) to be highlighted as a command argument (i.e., bold blue).
Minimal working example:
\documentclass[a4paper,parskip]{scrartcl}
\usepackage[utf8]{inputenc}
\usepackage{amsmath,amssymb,amsfonts}
\begin{document}
\section{Hello}
We know that $angle(x,p) \in [0,2\pi)$ must hold.
\end{document}
Essentially the newest version:
$ LC_ALL=C geany --version
geany 1.27 (git >= d1fcd9f) (built on 2016-01-03 with GTK 2.24.29, GLib 2.46.2)
The bugtracker does not seem to know this issue already. If this needs forwarding to ctags/scintilla/IDon'tKnow, please do that for me.
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/859
