> {
> ui_set_statusbar(TRUE, "%s", err->message);
> g_error_free(err);
> return FALSE;
> }
>
> - filedata->len = (gsize) st.st_size;
Yeah agreed it looked odd. FTR I just [traced it back to some encoding-related stuff](/geany/geany/commit/5331b0ada0bf655aa284c2712c98984c428b65da#diff-20352f47f8a14db7c31057b243a0ad26R637), no explanation why not using the size returned by the load function
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/621/files#r40503844
Should the very useful in editor terminal implement colour codes on Ubuntu? The attached screen shot shows what happens when I run in <b>Geany</b> as opposed to running in a terminal.
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/669
Just repushed with the "sorting by" as suggested by @elextr
@b4n I think it's actually good that the open documents don't change - users may change the sorting for individual open files manually and may not want them changed when the settings changes.
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/581#issuecomment-143505290
> {
> ui_set_statusbar(TRUE, "%s", err->message);
> g_error_free(err);
> return FALSE;
> }
>
> - filedata->len = (gsize) st.st_size;
Yeah, it was strange. But I actually feel safer to use the length from g_file_get_contents() and g_file_load_contents() - I don't think this should break anything.
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/621/files#r40499507
Thanks for the review. I have (finally) found some time to fix the various issues from the review. I've pushed them as a separate patch to make it easier to see what has been changed - I'll squash it with the previous commit if it's OK.
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/621#issuecomment-143503430
It would be very useful if "current chars" auto-indent mode would be aware of [PEP8 indentation guidelines](https://www.python.org/dev/peps/pep-0008/#indentation) while editing Python files. So it would auto-indent like, for example,
```python
foo = long_function_name(var_one, var_two,
var_three, var_four)
```
instead of
```python
foo = long_function_name(var_one, var_two,
var_three, var_four)
```
Cheers
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/668
> + g_free((gchar *)plugin->info->author);
> +
> + g_key_file_free(data->file);
> + g_free(data);
> +}
> +@endcode
> +
> +Finally the demo_proxy's wrapper GeanyPluginFuncs. They are called for each possible sub-plugin and
> +therefore have to multiplex between each using the plugin-defined data pointer. Each is called by
> +Geany as if it were an ordinary, native plugin.
> +
> +proxy_init() actually reads the inferior's file using GKeyFile APIs. It prepares for the help
> +dialog and installs the menu items. proxy_help() is called when the user clicks the help button in
> +the Plugin Manager. Consequently, this fires up a suitable dialog, although with a dummy message.
> +proxy_cleanup() frees all memory allocated in proxy_init().
> +
The entire section is all about the demo proxy. The introductory paragraph tells that the demo proxy loads plugins from ini files for demoing purposes. I don't know how to make it clearer
Am 25. September 2015 03:43:48 MESZ, schrieb elextr <notifications(a)github.com>:
>> + g_free((gchar *)plugin->info->author);
>> +
>> + g_key_file_free(data->file);
>> + g_free(data);
>> +}
>> +@endcode
>> +
>> +Finally the demo_proxy's wrapper GeanyPluginFuncs. They are called
>for each possible sub-plugin and
>> +therefore have to multiplex between each using the plugin-defined
>data pointer. Each is called by
>> +Geany as if it were an ordinary, native plugin.
>> +
>> +proxy_init() actually reads the inferior's file using GKeyFile APIs.
>It prepares for the help
>> +dialog and installs the menu items. proxy_help() is called when the
>user clicks the help button in
>> +the Plugin Manager. Consequently, this fires up a suitable dialog,
>although with a dummy message.
>> +proxy_cleanup() frees all memory allocated in proxy_init().
>> +
>
>It isn't clear if the ini file is just something this demo uses to
>define its sub-plugins, or if its required that all proxies use it, and
>if so why?
>
>---
>Reply to this email directly or view it on GitHub:
>https://github.com/geany/geany/pull/629/files#r40393473
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/629/files#r40405401
> +
> + plugin->proxy_funcs->probe = demoproxy_probe;
> + plugin->proxy_funcs->load = demoproxy_load;
> + plugin->proxy_funcs->unload = demoproxy_unload;
> +
> + return geany_plugin_register_proxy(plugin, extensions);
> +}
> +
> +@endcode
> +
> +The callback functions deserve a closer look.
> +
> +As already mentioned the file format includes a magic first line which must be present.
> +GeanyProxyFuncs::probe() verifies that it's present and avoids showing the sub-plugin in the
> +Plugin Manager if not.
> +
In this example section the implementations of the demo proxy are detailed. So the text does in fact describe what the function does (and not what it should do, although it refers to aforementioned requirements).
What the callbacks should do is detailed in an earlier section
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/629/files#r40405278
I used virtual space mode to insert 4 paragraph tags vertically in one go, but it only closed one tag - should it close them all?
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/663