> +
> + /* extract file extension to avoid g_str_has_suffix() in the loop */
> + ext = (const gchar *)strrchr(file, '.');
> + if (ext == NULL)
> + return FALSE;
> + /* ensure the dot is really part of the filename */
> + else if (strchr(ext, G_DIR_SEPARATOR) != NULL)
> + return FALSE;
> +
> + ext += 1;
> + /* O(n*m), (m being extensions per proxy) doesn't scale very well in theory
> + * but not a problem in practice yet */
> + foreach_list(node, active_proxies.head)
> + {
> + PluginProxy *proxy = node->data;
> + if (utils_str_casecmp(ext, proxy->extension) != 0)
This test is inverted, should be `==` It only "works" with C plugins by chance because they ship with a `.la` and for some reason loading this one also works.
Doesn't work with [geanypy port](https://github.com/kugel-/geany-plugins/commit/9c27df004f1c0906970da6…, no python plugins show up -- and geanypy probes and tried to load all C plugins.
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/629/files#r41171947
> @@ -712,6 +805,40 @@ static void remove_sources(Plugin *plugin)
> }
>
>
> +/* returns true if the plugin is native, i.e. not loaded through a proxy.
> + * This determines whether it's backed by a GModule */
this comment looks wrong
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/629/files#r41160837
![zoom1](https://cloud.githubusercontent.com/assets/7548378/10077620/00beed3a-62d9-11e5-8152-59e67b6ebb4e.png)
![zoom2](https://cloud.githubusercontent.com/assets/7548378/10077624/036d5bca-62d9-11e5-9eca-d62e59fe7e31.png)
I really like zooming with the mouse wheel with Ctrl held down, but to keep the text under the cursor as the zoom point I have to juggle the Shift and Ctrl keys as I zoom which is quite awkward. Would it be better to make the zoom centre on the cursor position rather than the start of the top most displayed line as it does now?
---
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/665