On 11 March 2014 19:35, shan chak <shankholove@gmail.com> wrote:
> Hi guys,
>
> My name is Shankhoneer Chakrovarty (aka 'shankhs' ), I have been using geany
> for past 3-4 years (mainly on my ubuntu ) and I have learned all my
> programming skills on geany. So thank you!
>
> Since I have been programming for 3-4 years now and also using geany, I
> thought it will be great if I could give something back to the geany
> community.
>
> I pulled the geany source code, read the HACKING file and created a patch
> which categorizes the compiler errors into "error" and "warning" and
> correspondingly draws a different colored squiggle underline in the line
> which caused the error. I have created the patch as mentioned in the hacking
> file and attached with this mail.
> If you guys have some time, can you please review the patch? If you need any
> more info, please feel free to drop me an email, I will be more than happy
> to explain it.

Have not reviewed it in detail, but some comments:

1. don't change whitespace (eg blank lines, that just makes noise in
the patch that is not needed making real review harder)
2. don't use doxygen comments for in-code comments
3. watch the layout, you are missing many spaces after commas
4. is setting a pointer to a piece of the string and comparing it to
"warning" really the best way of returning that information rather
than a bool or enum?
5. compiler lines are also parsed by filetypes_parse_compiler_line()

The preferred way of providing changes is now via pull requests on
github rather than patches.  The HACKING needs updating.

Cheers
Lex

>
> Also, I am reading the geany source code and modified some part of it to
> suit my personal needs so if you need a hand in resolving bugs, please do
> tell me. I am particularly interested in
> https://sourceforge.net/p/geany/bugs/254/ .

See also #907 :-D


>
> Thanks,
> Shankhoneer Chakrivarty
>
> _______________________________________________
> Devel mailing list
> Devel@lists.geany.org
> https://lists.geany.org/cgi-bin/mailman/listinfo/devel
>
_______________________________________________
Devel mailing list
Devel@lists.geany.org
https://lists.geany.org/cgi-bin/mailman/listinfo/devel