On Wed, Aug 19, 2015 at 11:52 AM, Thomas Martitz <kugel@rockbox.org> wrote:
Hello,


I would suggest removing the file saving option mentioned in (3) above and have just a single settings option like

use_gio_file_operations

Opinions?



 IIRC saving to temp file, then renaming isn't the default, because of concerns since both the rename and setting permissions can fail depending on the filesystem and permissions on the parent directly.

The use_gio_unsafe_file_saving=true is the default (and it should be kept this way) and it does the renaming.
 

IIRC#2 it's called unsafe because the above issues are even more apparent on remote file systems.

In my opinion use_atomic_file_saving=true is much worse on remote file systems because it destroys file metadata.
 
Cheers,

Jiri