Branch: refs/heads/master Author: Enrico Tröger enrico.troeger@uvena.de Committer: Enrico Tröger enrico.troeger@uvena.de Date: Sun, 06 Mar 2016 10:16:52 UTC Commit: 2f5eca2cfd0def376e7430f8f71ce9401cf2c0e1 https://github.com/geany/geany/commit/2f5eca2cfd0def376e7430f8f71ce9401cf2c0...

Log Message: ----------- Add error reporting for opening URIs on Windows

Before it silently failed if there was any error. Now at least a console warning is logged.

Modified Paths: -------------- src/win32.c

Modified: src/win32.c 10 lines changed, 9 insertions(+), 1 deletions(-) =================================================================== @@ -785,6 +785,7 @@ gint win32_check_write_permission(const gchar *dir) /* Just a simple wrapper function to open a browser window */ void win32_open_browser(const gchar *uri) { + gint ret; if (strncmp(uri, "file://", 7) == 0) { uri += 7; @@ -794,7 +795,14 @@ void win32_open_browser(const gchar *uri) uri++; } } - ShellExecute(NULL, "open", uri, NULL, NULL, SW_SHOWNORMAL); + ret = (gint) ShellExecute(NULL, "open", uri, NULL, NULL, SW_SHOWNORMAL); + if (ret <= 32) + { + gchar *err = g_win32_error_message(GetLastError()); + /* TODO add a GUI warning that opening an URI failed */ + g_warning("ShellExecute failed opening "%s" (code %d): %s", uri, ret, err); + g_free(err); + } }

-------------- This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).