[Geany] [PATCH] problem with default tools path settings

Yura Siamashka yurand2 at xxxxx
Wed Mar 12 11:16:47 UTC 2008


Hi

Today I desided to see if Arch linux can help me in building custom linux distributive, and I encounter pitfall.

Step to reproduce:

1) Install Arch
2) Install geany
3) run geany (It remember that my make_cmd is "" ;-) )
4) Install make

After this step "make" support is still broken since make_cmd firmly set to "". Even more it dangerously try to execute "all" or any other custom build target in sh. I think it is not very nice.

Here is two patches, each solve the problem:

1) If we get "" from settings try to find default tool in path.

2) If tool cmd is not set in config just use default value without any manipulation with g_find_program_in_path()
If we can find it with this function, then usage without full path will work too. So it should not be too smart.

As for me I like 2 solution better.

-- 
Best regards,
Yura Siamashka
-------------- next part --------------
A non-text attachment was scrubbed...
Name: keyfile_tools_fix1.patch
Type: application/octet-stream
Size: 1793 bytes
Desc: not available
URL: <http://lists.geany.org/pipermail/users/attachments/20080312/da37ba0b/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: keyfile_tools_fix2.patch
Type: application/octet-stream
Size: 1508 bytes
Desc: not available
URL: <http://lists.geany.org/pipermail/users/attachments/20080312/da37ba0b/attachment-0001.obj>


More information about the Users mailing list