[geany/geany-plugins] 8d0e3e: Check for NULL on arguments before using strcmp()

Enrico Tröger git-noreply at xxxxx
Tue Nov 7 06:09:32 UTC 2017


Branch:      refs/heads/master
Author:      Enrico Tröger <enrico.troeger at uvena.de>
Committer:   Enrico Tröger <enrico.troeger at uvena.de>
Date:        Tue, 07 Nov 2017 06:09:32 UTC
Commit:      8d0e3e52c37093113f76a70eb891d7d35ccb7f01
             https://github.com/geany/geany-plugins/commit/8d0e3e52c37093113f76a70eb891d7d35ccb7f01

Log Message:
-----------
Check for NULL on arguments before using strcmp()

Cppcheck warning:
tests.c:83: warning: Possible null pointer dereference: completion_needed


Modified Paths:
--------------
    xmlsnippets/src/tests.c

Modified: xmlsnippets/src/tests.c
2 lines changed, 1 insertions(+), 1 deletions(-)
===================================================================
@@ -80,7 +80,7 @@ static gboolean test(gint ordinal, const gchar *input, const gchar *completion_n
 	else if (!completion_needed && !success)
 		return TRUE;
 
-	if (strcmp(c.completion, completion_needed) != 0)
+	if (g_strcmp0(c.completion, completion_needed) != 0)
 	{
 		g_warning(
 			"Test %d: FAIL\n"



--------------
This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).


More information about the Plugins-Commits mailing list