[Github-comments] [geany/geany] Windows/GTK3: Message window reduces its height after restart (#2591)

[Enrico Tröger]

Thanks guys, for your suggestions.

Was could it have been?

- CSD
- any kind of timing issue related to setting the pane position
- nor a GTK bug
- ...

And the winner is:
some old _eht16-Windows-special-hack_

For reasons I don't remember anymore, I added in https://github.com/geany/geany/commit/9431eea2445ccf191777cf3667a9292cf4ddcb65 (in 2009) a Windows only change to realize the main windows *before* setting the window geometry and position.
Maybe it was related to off-screen window positions or so. Or some GTK2 behavior required it which is no longer the case.

After removing the `gtk_widget_realize` call, the message window height is stable, i.e. stays at where is has been left off. Also, I couldn't find any other negative impact of the removed call, even weird off-screen positions worked as expected (the window is moved to the visible screen area).

Too bad I don't know why the realize call was added initially :(.
At least, it pretty good explains why it happened only on Windows. Apparently, something in GTK3 has changed in that regard.

#2892 is here to fix it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2591#issuecomment-913163137
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20210905/e75f9454/attachment-0001.htm>