[Github-comments] [geany/geany] Default COLOR_DARK_RED may soon no longer be "red" (Issue #3016)

xiota notifications at xxxxx
Tue Nov 23 19:26:00 UTC 2021


After #3013, the default color of `COLOR_DARK_RED` may no longer be "red".  Would there be any objection to changing the enum in [msgwindow.h](https://github.com/geany/geany/blob/6856edd6511e8aa9a225098ac2aab9171b10167f/src/msgwindow.h#L34-L40)?

* `COLOR_RED` → `COLOR_ERROR`
* `COLOR_DARK_RED` → `COLOR_ORANGE` → `COLOR_CONTEXT`
* `COLOR_BLUE` → `COLOR_MESSAGE`

The change would mostly be find/replace.  Since these values are exported, the old ones would need to be retained and marked as deprecated.  Plugins that would need to be updated: spellcheck, geniuspaste, project organizer, geanyctags, ¿geanypy?

>From [`msgwindow.c`](https://github.com/geany/geany/blob/6856edd6511e8aa9a225098ac2aab9171b10167f/src/msgwindow.c#L296-L305):
```C
case COLOR_RED: return &color_error;
case COLOR_DARK_RED: return &color_context;
case COLOR_BLUE: return &color_message;
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3016
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20211123/b528eda4/attachment.htm>


More information about the Github-comments mailing list