[Github-comments] [geany/geany] Add keywords to the autocompletion list (#1146)

[Matthew Brush]

> @@ -1776,3 +1776,23 @@ gboolean highlighting_is_code_style(gint lexer, gint style)
>  	return !(highlighting_is_comment_style(lexer, style) ||
>  		highlighting_is_string_style(lexer, style));
>  }
> +
> +
> +gchar **highlighting_get_keywords(GeanyFiletypeID filetype_id)
> +{
> +	GString *str = g_string_sized_new(1000);
> +	gchar **keywords;
> +	gchar **keyword_str;
> +
> +	foreach_strv(keyword_str, style_sets[filetype_id].keywords)

This could be replaced with the more succinct and idiomatic:

```c
for (const char **kwd = style_sets[filetype_id].keywords; *kwd; kwd++)
```

Those `foreach_` macros only obfuscate the code and offer no benefit, IMO.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/1146/files/1e74c11aca41274d690d8da0b6e59b1247fbb222#r71964937
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160722/1fc5625e/attachment.html>