[Github-comments] [geany/geany-plugins] Gtk3 compatibility for geanydoc plugin (#467)

[Colomban Wendling]

> @@ -284,15 +284,14 @@ on_comboboxType_changed(GtkComboBox * combobox, G_GNUC_UNUSED gpointer user_data
>  
>  #define GLADE_HOOKUP_OBJECT(component,widget,name) \
>    g_object_set_data_full (G_OBJECT (component), name, \
> -    gtk_widget_ref (widget), (GDestroyNotify) gtk_widget_unref)
> +    g_object_ref (widget), (GDestroyNotify) gtk_widget_destroy)

`gtk_widget_destroy` isn't the same as `gtk_widget_unref`, `g_object_unref` would be a lot closer.  It may or may not change anything, depending on how it's used, but it probably would be "safer" to use `g_object_unref`

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/467/files/280902ad73fdee54c9df8dbbf79956652b73304f#r71738934
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.geany.org/pipermail/github-comments/attachments/20160721/e6a92e0b/attachment.html>