<div dir="ltr"><div></div>I didn't get it clear: If I add these doxygen comments, then there won't be any "implicit function declaration" warning and I'll get it compiled correctly?<br><br>OK for the rest.<br></div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><span style="font-family:arial,helvetica,sans-serif">Saludos,</span><i><span style="font-family:arial,helvetica,sans-serif"><br><br> Abel.</span></i><i><span style="font-family:arial,helvetica,sans-serif"></span></i></div></div></div></div></div>
<br><div class="gmail_quote">On 31 October 2015 at 11:55, Lex Trotman <span dir="ltr"><<a href="mailto:elextr@gmail.com" target="_blank">elextr@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 31 October 2015 at 20:39, Abel <<a href="mailto:akronix5@gmail.com">akronix5@gmail.com</a>> wrote:<br>
> I understand. I'm trying to solve the inconsistency of being editing a<br>
> document on split window but having the status bar showing something else<br>
> (Should I open a issue to report this bug?). So, yes, you can take this as a<br>
> request for the API :)<br>
<br>
</span>Umm, yeah, that sounds like a bug. And then you have something to<br>
refer to when you submit the PR with the changes.<br>
<span class=""><br>
><br>
> I haven't ever doxygened anything. But would it be enough for getting added<br>
> it to the API just adding doxygen comments to it?<br>
<br>
</span>The documentation is added by adding doxygen comments for the<br>
function, see doxygen docs and examples of other API functions.<br>
Generating the docs is in HACKING IIRC.<br>
<span class=""><br>
> I want to test that the<br>
> function is suitable for the purpose I want it for, before sending a PR for<br>
> getting it into the API.<br>
<br>
</span>Well, you can make and test the changes in your git clone first, and I<br>
think so long as its a separate commit, the changes to make the<br>
function available can be part of the PR that needs it. That way<br>
there are no dependencies between two PRs, one making the function<br>
available and one using it.<br>
<br>
Cheers<br>
<span class="HOEnZb"><font color="#888888">Lex<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
><br>
> Saludos,<br>
><br>
> Abel.<br>
><br>
> On 31 October 2015 at 11:28, Lex Trotman <<a href="mailto:elextr@gmail.com">elextr@gmail.com</a>> wrote:<br>
>><br>
>> Nothing is usually added to the API "just because" since it has to be<br>
>> maintained and supported and remain stable, and if the particular<br>
>> function is too deep in the implementation that may constrain later<br>
>> changes to Geany. Things are mostly added these days if a plugin has<br>
>> a need.<br>
>><br>
>> I guess we can take this as a request for the function to be added to the<br>
>> API :)<br>
>><br>
>> Maybe you can make a PR to speed the process. Note the need to<br>
>> doxygen document the function.<br>
>><br>
>> Cheers<br>
>> Lex<br>
>><br>
>><br>
>> On 31 October 2015 at 19:43, Abel <<a href="mailto:akronix5@gmail.com">akronix5@gmail.com</a>> wrote:<br>
>> > And why is not such function in the API? It's very used across all the<br>
>> > geany<br>
>> > code and there's no reason to think a plugin wouldn't ever want to use<br>
>> > it.<br>
>> ><br>
>> > I want to display the document statistics of the document opened on<br>
>> > split<br>
>> > window when it gets the focus. ui_set_statusbar() let you display text<br>
>> > but<br>
>> > doesn't give you access to create_statusbar_statistics() neither to<br>
>> > DEFAULT_STATUSBAR_TEMPLATE.<br>
>> ><br>
>> > Saludos,<br>
>> ><br>
>> > Abel.<br>
>> ><br>
>> > On 31 October 2015 at 03:59, Lex Trotman <<a href="mailto:elextr@gmail.com">elextr@gmail.com</a>> wrote:<br>
>> >><br>
>> >> See the big warning message at the start of the plugins doco<br>
>> >> <a href="http://www.geany.org/manual/reference/" rel="noreferrer" target="_blank">http://www.geany.org/manual/reference/</a> "Do not use any symbol not in<br>
>> >> the documentation".<br>
>> >><br>
>> >> On more recent versions of Geany the restriction on use of functions<br>
>> >> not in the API is better enforced to reduce the risk of accidental<br>
>> >> use. Functions not in the API never worked on Windows I believe, so a<br>
>> >> plugin that used non-API functions was not portable as well as<br>
>> >> possibly breaking without warning.<br>
>> >><br>
>> >> Can you not use<br>
>> >><br>
>> >><br>
>> >> <a href="http://www.geany.org/manual/reference/ui__utils_8h.html#aa0948006d2f45a2a2a6b7da40169b8ac" rel="noreferrer" target="_blank">http://www.geany.org/manual/reference/ui__utils_8h.html#aa0948006d2f45a2a2a6b7da40169b8ac</a><br>
>> >><br>
>> >> Cheers<br>
>> >> Lex<br>
>> >><br>
>> >> On 31 October 2015 at 12:47, Abel <<a href="mailto:akronix5@gmail.com">akronix5@gmail.com</a>> wrote:<br>
>> >> > Hi!<br>
>> >> ><br>
>> >> > I'm hacking split window plugin and I wanted to use the function<br>
>> >> > ui_update_statusbar(), located in ui_utils.h<br>
>> >> ><br>
>> >> > When I try to compile I get the following warning:<br>
>> >> ><br>
>> >> > "warning: implicit declaration of function 'ui_update_statusbar'<br>
>> >> > [-Wimplicit-function-declaration]"<br>
>> >> ><br>
>> >> > And if I try yo execute the bin generated it doesn't allow you to<br>
>> >> > enable<br>
>> >> > that plugin, it is never shown anymore.<br>
>> >> ><br>
>> >> > The plugin includes geanyplugin.h which in turn includes ui_utils.h<br>
>> >> ><br>
>> >> > Some help or hints?<br>
>> >> ><br>
>> >> > _______________________________________________<br>
>> >> > Devel mailing list<br>
>> >> > <a href="mailto:Devel@lists.geany.org">Devel@lists.geany.org</a><br>
>> >> > <a href="https://lists.geany.org/cgi-bin/mailman/listinfo/devel" rel="noreferrer" target="_blank">https://lists.geany.org/cgi-bin/mailman/listinfo/devel</a><br>
>> >> ><br>
>> >> _______________________________________________<br>
>> >> Devel mailing list<br>
>> >> <a href="mailto:Devel@lists.geany.org">Devel@lists.geany.org</a><br>
>> >> <a href="https://lists.geany.org/cgi-bin/mailman/listinfo/devel" rel="noreferrer" target="_blank">https://lists.geany.org/cgi-bin/mailman/listinfo/devel</a><br>
>> ><br>
>> ><br>
>> ><br>
>> > _______________________________________________<br>
>> > Devel mailing list<br>
>> > <a href="mailto:Devel@lists.geany.org">Devel@lists.geany.org</a><br>
>> > <a href="https://lists.geany.org/cgi-bin/mailman/listinfo/devel" rel="noreferrer" target="_blank">https://lists.geany.org/cgi-bin/mailman/listinfo/devel</a><br>
>> ><br>
>> _______________________________________________<br>
>> Devel mailing list<br>
>> <a href="mailto:Devel@lists.geany.org">Devel@lists.geany.org</a><br>
>> <a href="https://lists.geany.org/cgi-bin/mailman/listinfo/devel" rel="noreferrer" target="_blank">https://lists.geany.org/cgi-bin/mailman/listinfo/devel</a><br>
><br>
><br>
><br>
> _______________________________________________<br>
> Devel mailing list<br>
> <a href="mailto:Devel@lists.geany.org">Devel@lists.geany.org</a><br>
> <a href="https://lists.geany.org/cgi-bin/mailman/listinfo/devel" rel="noreferrer" target="_blank">https://lists.geany.org/cgi-bin/mailman/listinfo/devel</a><br>
><br>
_______________________________________________<br>
Devel mailing list<br>
<a href="mailto:Devel@lists.geany.org">Devel@lists.geany.org</a><br>
<a href="https://lists.geany.org/cgi-bin/mailman/listinfo/devel" rel="noreferrer" target="_blank">https://lists.geany.org/cgi-bin/mailman/listinfo/devel</a><br>
</div></div></blockquote></div><br></div>