<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On 11 August 2013 23:31, Nick Treleaven <span dir="ltr"><<a href="mailto:git-noreply@geany.org" target="_blank">git-noreply@geany.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Branch:      refs/heads/master<br>
Author:      Nick Treleaven <<a href="mailto:nick.treleaven@btinternet.com">nick.treleaven@btinternet.com</a>><br>
Committer:   Nick Treleaven <<a href="mailto:nick.treleaven@btinternet.com">nick.treleaven@btinternet.com</a>><br>
Date:        Sun, 11 Aug 2013 13:31:30 UTC<br>
Commit:      0c7cf8df103232a5ccee7da4e46d611b35eae033<br>
             <a href="https://github.com/geany/geany/commit/0c7cf8df103232a5ccee7da4e46d611b35eae033" target="_blank">https://github.com/geany/geany/commit/0c7cf8df103232a5ccee7da4e46d611b35eae033</a><br>
<br>
Log Message:<br>
-----------<br>
Fix gcc warning 'cast to pointer from integer of different size'<br>
<br>
<br>
Modified Paths:<br>
--------------<br>
    tagmanager/src/tm_workspace.c<br>
<br>
Modified: tagmanager/src/tm_workspace.c<br>
2 files changed, 1 insertions(+), 1 deletions(-)<br>
===================================================================<br>
@@ -207,7 +207,7 @@ static guint tm_file_inode_hash(gconstpointer key)<br>
 #ifdef TM_DEBUG<br>
                g_message ("Hash for '%s' is '%d'\n", filename, file_stat.st_ino);<br>
 #endif<br>
-               return g_direct_hash (GUINT_TO_POINTER (file_stat.st_ino));<br>
+               return g_direct_hash (GUINT_TO_POINTER ((guint)file_stat.st_ino));<br></blockquote><div><br></div><div>Hi Nick,</div><div><br></div><div>On 64 bit Linux ino_t is 64 bits, but guint is 32 bits so this has the potential to truncate inode numbers, you should cast to gulong.</div>
<div><br></div><div>Note from the Glib docs on GUINT_TO_POINTER "#define GUINT_TO_POINTER(u) ((gpointer) (gulong) (u))"</div><div><br></div><div>Cheers</div><div>Lex</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">

        } else {<br>
                return 0;<br>
        }<br>
<br>
<br>
<br>
--------------<br>
This E-Mail was brought to you by github_commit_mail.py (Source: <a href="https://github.com/geany/infrastructure" target="_blank">https://github.com/geany/infrastructure</a>).<br>
_______________________________________________<br>
Commits mailing list<br>
<a href="mailto:Commits@lists.geany.org">Commits@lists.geany.org</a><br>
<a href="https://lists.geany.org/cgi-bin/mailman/listinfo/commits" target="_blank">https://lists.geany.org/cgi-bin/mailman/listinfo/commits</a><br>
</blockquote></div><br></div></div>