<br><div class="gmail_extra">I can't find the mail with the patch quickly so I havn't looked at it.<br><br><div class="gmail_quote">On 6 November 2012 02:02, Colomban Wendling <span dir="ltr"><<a href="mailto:lists.ban@herbesfolles.org" target="_blank">lists.ban@herbesfolles.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Le 03/05/2012 13:41, Quentin Glidic a écrit :<br>
> Hello,<br>
<br>
Hi,<br>
<br>
> Attached a little patch concerning the file saving dialog.<br>
> I may have missed some use cases, but it works on all cases mentioned in<br>
> the commit message.<br>
><br>
> The main point is about the “Rename†, the unsaved file one (last<br>
> commit message line) is a bonus.<br>
<br>
I agree that "Open in new tab" shouldn't have precedence over "Rename".<br>
<br>
However, I'm not completely sure about the change on "Open in new tab"<br>
behavior, e.g. that it has no effect either when renaming or when the<br>
file wasn't yet saved. Upon rename, I agree it doesn't seem to make<br>
much sense, because the original tab would become "orphaned", and would<br>
show a "hey, I'm not found on disk!". But I can imagine one would save<br>
to file while keeping the unsaved buffer open (maybe to save it to<br>
another file again later on) -- OK, I don't have such use-case myself.<br></blockquote><div><br></div><div><br></div><div>It makes sense to me when used on the save-as dialog, ie keep the old file open in another tab as well as saving this one under a new filename. But I agree it doesn't make sense on rename, but how to know that the user is going to rename to grey it out?</div>
<div><br></div><div>But neither open in new tab or rename makes sense on the save dialog, its just that we are too lazy to define different save dialog versions IIUC :)</div><div><br></div><div>If save and save-as are to remain the same dialog then only save and cancel should be sensitive on the save dialog.</div>
<div><br></div><div>Cheers</div><div>Lex</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
So, on this subject, open question: what do other think? I'm OK with<br>
the proposed behavior, but as said I could understand somebody wanting<br>
to keep "open in new tab" with unsaved files; but if no one cares it<br>
probably makes the thing more intuitive to remove it (e.g. no unsaved<br>
file after save).<br>
<br>
<br>
Anyway, the UI should reflect the behavior, e.g. the "Open in new tab"<br>
checkbox should be sensitive only if it will be used (with your patch,<br>
when doc->file_name != NULL).<br>
<br>
Regards,<br>
Colomban<br>
<br>
<br>
PS: BTW, please stick to ASCII in commit messages :)<br>
_______________________________________________<br>
Devel mailing list<br>
<a href="mailto:Devel@lists.geany.org" target="_blank">Devel@lists.geany.org</a><br>
<a href="https://lists.geany.org/cgi-bin/mailman/listinfo/devel" target="_blank">https://lists.geany.org/cgi-bin/mailman/listinfo/devel</a><br>
</blockquote></div><br></div>