<br><br><div class="gmail_quote">2009/7/17 Enrico Tröger <span dir="ltr"><<a href="mailto:enrico.troeger@uvena.de">enrico.troeger@uvena.de</a>></span><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div><div></div><div class="h5">On Thu, 9 Jul 2009 17:38:57 +1000, Lex wrote:<br>
<br>
>An extra Known Bug so Nick and Enciro don't beat me up<br>
><br>
>Source formatting and especially very long lines not yet fixed. (well<br>
>they fit on my widescreen monitor)<br>
<br>
</div></div>A very few general notes:<br>
<br>
- I think it'd better if you would format your code properly while<br>
writing. This is probably harder for you since you are not used to use<br>
our coding style but it would be easier for us to read and review the<br>
code and I think it would be easier than reformatting all at once when<br>
you are finished with your branch. But it's just a suggestion.</blockquote><div><br>Hopefully getting better :-) build.c should now be mostly matching the standard in Hacking I think. If not let me know.<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
<br>
- you really should fix the compiler warnings, I get a whole bunch when<br>
compiling the code (see attachment). Most of them are harmless like<br>
unused variables but the more warnings you usually have, the bigger the<br>
danger is to overlook a real warning which you want to see<br>
</blockquote><div><br>I don't get any of these, is there an option I need to give make or configure to make it picky???<br><br>Should be all fixed, but I can't actually check since I don't get them.<br>BTW the filetypes one was useful, but most build ones were just annoying thankfully.<br>
<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
- the build settings dialog needs love. First, it needs some spacing<br>
between the GUI elements to match the other Geany dialogs look&feel and<br>
also to be more compliant with the Gnome HIG. But this is low priority<br>
and can be improved later as this is GUI stuff only.</blockquote><div><br>No problem, whats your standard spacing etc? <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
<br>
- the build settings dialog looks already very big and a bit cluttered.</blockquote><div><br>Agree <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
Not yet sure whether we can improve this, will think about this a bit.<br>
But at least, please don't make it even bigger. Imagine you are a new<br>
user and just want to change the Run command, in the current dialog you<br>
first need to figure out which field does what and where the field is<br>
you actually want to edit.<br>
Don't get me wrong, it's pretty cool so far but maybe we can make it<br>
even cooler. And I'm not one of those Gnome guys who somtimes like<br>
hide/remove any option from the user. But there is also the other way<br>
to overload the GUI with useless stuff. And so, I'm just about to find<br>
a best way in between :).<br>
<div><div></div><div class="h5"></div></div></blockquote><div><br>I agree, its now the biggest dialog in Geany, its just that there is a certain amount of functionality to configure, any suggestions welcome, but I can't see a sensible way of dividing it up to make it smaller. <br>
At the moment it reflects the way the menu is laid out. I think its important to keep that relationship for easy use. <br>Dividing it vertically doesn't really make sense either, label and command need to be together, and putting working dir on another tab or something is really messy because then I would be skipping back and forward to see which directories related to which commands. Maybe we *have* to be Gnomic and have the working dir column hidden unless the user selects to make it visible. <br>
As you say needs some thought.<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div><div class="h5"><br>
<br>
Regards,<br>
Enrico<br>
<br>
--<br>
Get my GPG key from <a href="http://www.uvena.de/pub.asc" target="_blank">http://www.uvena.de/pub.asc</a><br>
</div></div><br>_______________________________________________<br>
Geany-devel mailing list<br>
<a href="mailto:Geany-devel@uvena.de">Geany-devel@uvena.de</a><br>
<a href="http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel" target="_blank">http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel</a><br>
<br></blockquote></div><br>