<div dir="ltr"><br><br><div class="gmail_quote">On Sat, Oct 11, 2008 at 4:24 AM, Nick Treleaven <span dir="ltr"><<a href="mailto:nick.treleaven@btinternet.com">nick.treleaven@btinternet.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hi,<br>
I've committed Lex Trotman's geany.txt changes in the build-system<br>
branch, slightly edited.<br>
<br>
<a href="https://geany.svn.sourceforge.net/svnroot/geany/branches/build-system" target="_blank">https://geany.svn.sourceforge.net/svnroot/geany/branches/build-system</a><br>
<br>
I made some formatting changes:<br>
.. note:: syntax (space after ..)<br>
break lines - I used the 'Format->Send selection to command' with the<br>
fmt command.</blockquote><div> </div><div>Thanks<br> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
On to the changes - in general I agree with them, but some points:<br>
<br>
1. 'Make Commands' is mentioned, perhaps this should be renamed 'Global<br>
Commands', as these may well be nothing to do with 'make'.</blockquote><div> </div><div>I agree it should be changed from 'Make' but I had trouble getting a term I was happy with.<br>This was a general issue throughout the document, what group term to use for the builder commands?<br>
Builder itself I thought was too close to the 'build' command which doesn't use the builder ;-)<br>"Global" I felt could be taken as a reference to storing them globally and what is being implemented<br>
is actually storing them in the Project file or user prefs. Unless the build command is changed <br>allowing the use of builder as the group name for the make commands?<br><br>Looking at the prototype dialog attached, it doesn't look like so much a problem for the software, <br>
just to avoid confusion in the manual.<br><br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
2.<br>
+* From the user preferences if the user has make commands defined.<br>
+* From the global preferences/defaults.<br>
<br>
Not sure about this - currently we only have user prefs for geany.conf.<br>
Maybe global prefs too, but would it be confusing?<br>
</blockquote><div><br>Ok, its user preferences or Defaults.<br> <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
3. Do we need the table of default filetype build commands? If so, IMO<br>
it should be autogenerated and included/referenced from geany.txt<br>
rather than writing by hand.<br>
</blockquote><div><br>I think it is useful to let the user know what the defaults are so they don't need to go look.<br>But it probably should be in an appendix and referenced from here. <br>Autogenerating I like, you can see how far I got manually.<br>
</div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
4. I think 'Project Make' should be configured from the Project<br>
Properties dialog. In this case the global Make command could be<br>
grayed out in the Configure Commands dialog.</blockquote><div><br> IMO its better UI practice to have all the build menu commands configured from the one dialog box <br>activated from the build menu.<br>Attached is a quick mockup of the dialog,<br>
Note that the label "Commands for filetype C" will change to the type of the current file, <br>eg "Commands for filetype Python". <br>Note also that the label "Project Builder Commands" will be "Preferred Builder Commands" if no project is open.<br>
<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
<br>
5.<br>
+Remember that menu item two (default the 'Make Custom Target' item)<br>
+will pop up a dialog to ask for additional targets/options when invoked<br>
+allowing you to add to the command you define here.<br>
<br>
Should this just be the 'Make Custom Target' item? (not menu item two)<br>
</blockquote><div><br>Well the section was talking about changing the menu labels and commands so it <br>might not say "Make Custom Target", hence my hedging it by putting it in brackets and <br>noting it as default. Menu item two is somewhat ugly maybe "the second menu item" but<br>
any better suggestions for referring to a menu item independently of its label will be gratefully<br>received.<br> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
Regards,<br>
Nick<br>
_______________________________________________<br>
Geany-devel mailing list<br>
<a href="mailto:Geany-devel@uvena.de">Geany-devel@uvena.de</a><br>
<a href="http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel" target="_blank">http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel</a><br>
</blockquote></div><br><br>Regards<br>Lex<br></div>