[Geany-Devel] codesubmit plugin
Frank Lanitz
frank at xxxxx
Wed Feb 27 09:49:16 UTC 2013
Am 27.02.2013 00:08, schrieb Mayank Jha:
> To all esteemed developers Frank Lanitz, Matthew Brush. Kindly review my
> code which i have modified according to your suggestions.
My note without looking into it to much:
- README is missing
- Licence is missing
- Make usage of PLUGIN_SET_TRANSLATABLE_INFO() in combination mit
#include "config.h" (check other plugins for it if needed)
- Provide a proper patch against geany-plugins including all files
- Do you really need to use fprintf() so excessive starting from line
239 as it appears its only static content
- Please check formatting of your code
http://geany.org/manual/dev/hacking.html should also apply to plugins
in most cases
- Use C90 compatible code
- switch in l96 is not having a default case
Cheers,
Frank
More information about the Devel
mailing list