[Geany-devel] Empty project properties dialog

[Matthew Brush]

On 01/11/2012 04:11 PM, Jiří Techet wrote:
> On Mon, Jan 9, 2012 at 01:05, Matthew Brush<mbrush at codebrainz.ca>  wrote:
>> On 12/26/2011 01:37 PM, Jiří Techet wrote:
>>>
>>> Hi,
>>>
>>> I'm experiencing a bug where the project properties dialog is empty
>>> when opened for the second time. Steps to reproduce:
>>>
>>> 1. Open project properties dialog.
>>> 2. Close it.
>>> 3. Open it for the second time.
>>>
>>> Result: the project properties dialog is much smaller and it's empty.
>>>
>>> I suspect it's related to the GtkBuiler transition. I haven't looked
>>> into it because I guess Matthew knows better what might be wrong.
>>>
>>
>> I fixed this in:
>> https://github.com/geany/geany/commit/0755b44db1a238a65d7b3cec7f8b11430c8b2f1e
>>
>> If you don't mind to test around the project preferences dialog a bit to see
>> if you can spot any more problems it would great.
>
> In general it seems to be fixed.
>
> However, there's one related problem - in GProject I add additional
> tab to the dialog. At the moment I'm adding the tab every time the
> dialog appears because before the GtkBuilder changes the dialog was
> destroyed once it was closed. Now it seems you reuse the same dialog
> which means I should change the GProject behavior otherwise new and
> new GProject tabs are added every time the dialog appears. If this new
> behavior is official then the plugins API version should be bumped
> because it changes their behavior.
>

Yeah, I guess that couldn't hurt, although according to the docs, this 
is how the API version is supposed to be used[1]:

"The Application Programming Interface (API) version, incremented 
whenever any plugin data types are modified or appended to."

Which is why I never touched the API version, since it's quite clear 
when to increment it[2].

Cheers,
Matthew Brush

[1] Although I personally dislike this in general since it does not give 
any indication when new functions are added or removed or like this case 
where behaviour is changed, nor does it give any correlation between API 
version and the currently running version of Geany. In other words, it 
seems basically useless, IMO.

[2] Despite the example in the same comment that shows it being used to 
guard a function, which can't actually be guarded since there's no way 
to know what API version to check for functions.