[Geany-devel] Weird Segfault Crash

[Lex Trotman]

On Tue, Jan 3, 2012 at 1:33 AM, Colomban Wendling
<lists.ban at herbesfolles.org> wrote:
> Hi,
>
> Le 02/01/2012 06:01, Matthew Brush a écrit :
>> Hi,
>>
>> I'm having some random crashes, possibly due to bad tag files?  Patch
>> attached "fixes" the segfault, but I'm pretty sure it's not the
>> "correct" fix.
>
> Well, you spotted a quite complex bug in tag encoding management...
> what we currently do is to assume tag's strings are encoded in the
> document's encoding, which is probably true for document tags but not
> necessarily for global tags.
>
> I'm not sure what would be the right fix... we either need to always
> have the same encoding in a TMTag (better be UTF8), or we need to have a
> way to find what's the tag's encoding (e.g. a new TMTag field, ouch).

I agree the only way is to have all tag files have the same UTF-8
encoding.  Since we only read tag files we write that shouldn't be a
problem.

[...]
Cheers
Lex