[Geany-devel] gtkbuilder branch and ui_lookup_widget functions

[Nick Treleaven]

On 18/10/2011 22:57, Matthew Brush wrote:
> On 11-10-18 01:33 PM, Matthew Brush wrote:
>
>> Not really (I'm kinda stupid remember :) I think I'm confused about how
>> it used to work and you're confused about how it works now :)
>>
>
> I think I see what you're talking about, ui_hookup_widget() is attaching
> the widget to the owner Gobject's datalist. Ok, I think to avoid fixing
> all of Geany's code that uses this, I will make the new
> ui_hookup_object() to do this same thing as well, then we can worry more
> about getting rid of what's left once we port the rest of the UI to
> GtkBuilder.
>
> I'll report back once I've got it working and we can go from there.

I'm currently fighting off flu so can't look at the new branch yet.

Just to make sure we understand each other; basically, the 
ui_[l]ookup_widget changes should be reverted. Then, if ui_lookup_widget 
fails, for compatibility it can try your hashtable lookup.

New code that wants to lookup a widget created from geany's glade xml 
can use your new function to lookup an object from the hashtable. 
Looking up some non-geany non-global widget still needs to use 
ui_[lh]ookup_widget.

BTW name clashes are definitely possible if we only use your global 
hashtable, which is why we need the old functions to work like they used 
to. Even if it works with the global lookup now doesn't mean it's doing 
the right thing.

I don't think I misunderstood any of your explanations.

I'm not on IRC but I could use IM maybe. I'm usually online between 12pm 
- 6pm monday-friday UK time.

Regards,
Nick