[geany/geany] 99180d: build.c: Only set next/prev error menu items sensitive on first error

[Nick Treleaven]

Branch:      refs/heads/master
Author:      Nick Treleaven <n at trelsoft.com>
Committer:   Nick Treleaven <n at trelsoft.com>
Date:        Tue, 08 Oct 2019 13:22:20 UTC
Commit:      99180dbc6b62ceddcc3de6dcabcae266bdbdc6c3
             https://github.com/geany/geany/commit/99180dbc6b62ceddcc3de6dcabcae266bdbdc6c3

Log Message:
-----------
build.c: Only set next/prev error menu items sensitive on first error


Modified Paths:
--------------
    src/build.c
    src/msgwindow.c

Modified: src/build.c
6 lines changed, 6 insertions(+), 0 deletions(-)
===================================================================
@@ -1026,6 +1026,12 @@ static void process_build_output_line(gchar *msg, gint color)
 		}
 		build_info.message_count++;
 		color = COLOR_RED;	/* error message parsed on the line */
+
+		if (build_info.message_count == 1)
+		{
+			gtk_widget_set_sensitive(build_get_menu_items(-1)->menu_item[GBG_FIXED][GBF_NEXT_ERROR], TRUE);
+			gtk_widget_set_sensitive(build_get_menu_items(-1)->menu_item[GBG_FIXED][GBF_PREV_ERROR], TRUE);
+		}
 	}
 	g_free(filename);
 


Modified: src/msgwindow.c
4 lines changed, 0 insertions(+), 4 deletions(-)
===================================================================
@@ -374,10 +374,6 @@ void msgwin_compiler_add_string(gint msg_color, const gchar *msg)
 		gtk_tree_path_free(path);
 	}
 
-	/* calling build_menu_update for every build message would be overkill, TODO really should call it once when all done */
-	gtk_widget_set_sensitive(build_get_menu_items(-1)->menu_item[GBG_FIXED][GBF_NEXT_ERROR], TRUE);
-	gtk_widget_set_sensitive(build_get_menu_items(-1)->menu_item[GBG_FIXED][GBF_PREV_ERROR], TRUE);
-
 	if (utf8_msg != msg)
 		g_free(utf8_msg);
 }



--------------
This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).