[geany/geany] a6b143: Fix modulo by zero, resulting in FPE

Colomban Wendling git-noreply at xxxxx
Wed May 7 14:00:49 UTC 2014


Branch:      refs/heads/master
Author:      Colomban Wendling <ban at herbesfolles.org>
Committer:   Colomban Wendling <ban at herbesfolles.org>
Date:        Wed, 07 May 2014 14:00:49 UTC
Commit:      a6b1433e6673d4cdb159818187233f0cde3245e8
             https://github.com/geany/geany/commit/a6b1433e6673d4cdb159818187233f0cde3245e8

Log Message:
-----------
Fix modulo by zero, resulting in FPE

Fix modulo zero error resulting in floating point exception, and then
crash. This was introduced in fd6ce2da11e9f2d20cb96236753662c23feaecb4.

Closes #265.


Modified Paths:
--------------
    src/keyfile.c

Modified: src/keyfile.c
2 lines changed, 1 insertions(+), 1 deletions(-)
===================================================================
@@ -1203,7 +1203,7 @@ void configuration_open_files(void)
 		gint target_page = session_notebook_page >= 0 ? session_notebook_page : cur_page;
 
 		/* if target page is current page, switch to another page first to really trigger an event */
-		if (target_page == cur_page)
+		if (target_page == cur_page && n_pages > 0)
 			gtk_notebook_set_current_page(GTK_NOTEBOOK(main_widgets.notebook), (cur_page + 1) % n_pages);
 
 		main_status.opening_session_files = FALSE;



--------------
This E-Mail was brought to you by github_commit_mail.py (Source: https://github.com/geany/infrastructure).


More information about the Commits mailing list